Conversation
Documentation ReviewI've reviewed PR #16768 which updates the security PGP key. Here are my findings: ✅ Positive Changes
📝 ObservationsSecurity Content Update:
This appears to be a legitimate security key rotation, which is a good security practice. The move to Ed25519 is also aligned with modern cryptographic best practices. ℹ️ Style ComplianceThe changes comply with the repository's style guidelines:
✅ VerdictNo issues found. The changes are appropriate for a security key rotation. Need additional reviews or fixes? Mention me (@claude) in the comments. |
There was a problem hiding this comment.
Pull request overview
This PR updates the PGP public key published on the Pulumi security page. The change replaces an older key associated with team@pulumi.com with a new key specifically designated for security communications at security@pulumi.com, providing better alignment with the documented security contact email and improved security practices through key rotation.
- Replaces the PGP public key block with a new, refreshed key
- Updates the key identifier from "Pulumi Team" to "Pulumi Security (Used for security emails)"
- Aligns the key's email address with the actual security contact email used throughout the page
|
Your site preview for commit e0857e6 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16768-e0857e61.s3-website.us-west-2.amazonaws.com. |
|
Looks good, is the new private key available in 1password so we can be sure to decrypt reports sent with this? Some info around expiration date etc would be good to have in the shared record as well. |
|
Everything else is documented in the ticket |
Proposed changes
This refreshes and updates the PGP key we publish on pulumi.com/security
Related issues (optional)
https://github.com/pulumi/home/issues/4031